Skip to content

fix: mitigation of xgboost container incompatibility with new version #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 6, 2023
Merged

fix: mitigation of xgboost container incompatibility with new version #4298

merged 4 commits into from
Dec 6, 2023

Conversation

SSRraymond
Copy link
Contributor

@SSRraymond SSRraymond commented Dec 4, 2023 •
edited
Loading

Issue #, if available:
#4288

Description of changes:

  • Install old version in inference.py when using 1P xgboost container
  • Restrict sagemaker>=2.199 to ensure it installed version with ModelBuilder

Testing done:

  • Ran XGBoost notebook
  • Ran pytorch notebook
  • Unit testing all passed
  • Formatting all passed

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SSRraymond SSRraymond requested a review from a team as a code owner December 4, 2023 21:27
@SSRraymond SSRraymond requested review from zuoyuanh and removed request for a team December 4, 2023 21:27
@SSRraymond SSRraymond requested review from mohanasudhan, gwang111, knikure and a team December 4, 2023 21:28
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: bba18b6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: bba18b6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: c406f1e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: c406f1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: c406f1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: c406f1e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57fd632) 86.72% compared to head (c406f1e) 86.60%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4298      +/-   ##
==========================================
- Coverage   86.72%   86.60%   -0.13%     
==========================================
  Files        1197      380     -817     
  Lines      105633    34821   -70812     
==========================================
- Hits        91609    30155   -61454     
+ Misses      14024     4666    -9358

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: c406f1e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure linked an issue Dec 5, 2023 that may be closed by this pull request
ModelBuilder support for XGBoost container is impaired due to boto3 dependencies issues #4288
Closed
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 59f1bf4
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 59f1bf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 59f1bf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 59f1bf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 59f1bf4
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knikure knikure merged commit 3ed0011 into aws:master Dec 6, 2023
@SSRraymond SSRraymond deleted the server branch December 6, 2023 19:07
knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request May 8, 2024
@SSRraymond @sagemaker-bot
fix: mitigation of xgboost container incompatibility with new version (…
bd082ec 
…aws#4298)

Co-authored-by: Raymond Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohanasudhan mohanasudhan mohanasudhan approved these changes

@gwang111 gwang111 gwang111 approved these changes

@mufaddal-rohawala mufaddal-rohawala mufaddal-rohawala approved these changes

@zuoyuanh zuoyuanh Awaiting requested review from zuoyuanh zuoyuanh is a code owner automatically assigned from aws/sagemaker-ml-frameworks

@knikure knikure Awaiting requested review from knikure

Assignees

@knikure knikure

Labels
component: model builder type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ModelBuilder support for XGBoost container is impaired due to boto3 dependencies issues
6 participants
@SSRraymond @mufaddal-rohawala @codecov-commenter @mohanasudhan @gwang111 @knikure