Skip to content

fix: update image and hardware validation with inf and graviton #4299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

SSRraymond
Copy link
Contributor

@SSRraymond SSRraymond commented Dec 4, 2023

Issue #, if available:

Description of changes:

  • Add image and instance type validation for inf and graviton

Testing done:

  • Unit test
  • Formatting

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SSRraymond SSRraymond requested a review from a team as a code owner December 4, 2023 22:45
@SSRraymond SSRraymond requested review from sthodimi, gwang111, mohanasudhan and knikure and removed request for a team and sthodimi December 4, 2023 22:45
@SSRraymond SSRraymond changed the title update image and hardware validation with inf and graviton fix: update image and hardware validation with inf and graviton Dec 4, 2023
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-local-mode-tests
  • Commit ID: 5a60731
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-notebook-tests
  • Commit ID: 5a60731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 5a60731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-slow-tests
  • Commit ID: 5a60731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-unit-tests
  • Commit ID: 5a60731
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (57fd632) 86.72% compared to head (5a60731) 86.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4299      +/-   ##
==========================================
- Coverage   86.72%   86.60%   -0.12%     
==========================================
  Files        1197      380     -817     
  Lines      105633    34836   -70797     
==========================================
- Hits        91609    30170   -61439     
+ Misses      14024     4666    -9358     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knikure knikure merged commit 99afcc8 into aws:master Dec 5, 2023
@SSRraymond SSRraymond deleted the image branch December 6, 2023 19:07
knikure pushed a commit to knikure/sagemaker-python-sdk that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants