feat: retrieve jumpstart estimator and predictor without specifying model id (infer from tags) #4304

evakravi · 2023-12-05T13:37:29Z

Description of changes:
Allows customers to do sagemaker.predictor.retrieve_default("jumpstart-endpoint-name") and sagemaker.jumpstart.estimator.attach("jumpstart-training-job-name"). The model id is inferred from the tags of the AWS resource (if present).

Testing done:
Unit tests added, manually tested as well

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…odel id (infer from tags)

mufaddal-rohawala · 2023-12-05T13:43:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 21177c4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-predictor-without-model-id

mufaddal-rohawala · 2023-12-05T13:52:21Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 8086f6e
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T14:41:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 8086f6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T14:46:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 8086f6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T14:50:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 8086f6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T15:22:46Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 8086f6e
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

JGuinegagne

please add support for all JumpStart tags, not just the SDK tags:

classic Studio tags
Monarch tags
SDK tags as you have them

what happens if the model version is not supported by the current SDK?
what is the story for InferenceComponent-based endpoints?

src/sagemaker/jumpstart/estimator.py

src/sagemaker/jumpstart/utils.py

src/sagemaker/predictor.py

src/sagemaker/utils.py

tests/unit/sagemaker/jumpstart/estimator/test_estimator.py

JGuinegagne · 2023-12-05T16:13:08Z

tests/unit/sagemaker/jumpstart/test_predictor.py

+@patch("sagemaker.predictor.get_jumpstart_model_id_version_from_endpoint")
+@patch("sagemaker.jumpstart.utils.verify_model_region_and_return_specs")
+@patch("sagemaker.jumpstart.accessors.JumpStartModelsAccessor.get_model_specs")
+def test_jumpstart_predictor_support_no_model_id_supplied_sad_case(


same comment please

tests/unit/sagemaker/jumpstart/test_utils.py

mufaddal-rohawala · 2023-12-05T16:50:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 69b2929
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T17:02:11Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 69b2929
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T17:04:25Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 69b2929
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T17:26:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 69b2929
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-05T17:52:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 69b2929
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-12-05T17:53:49Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b206ba) 86.94% compared to head (13b7b2c) 86.88%.
Report is 2 commits behind head on master.

Files	Patch %	Lines
src/sagemaker/jumpstart/session_utils.py	98.11%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4304      +/-   ##
==========================================
- Coverage   86.94%   86.88%   -0.06%     
==========================================
  Files        1203      383     -820     
  Lines      107211    35397   -71814     
==========================================
- Hits        93211    30756   -62455     
+ Misses      14000     4641    -9359

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-predictor-without-model-id

mufaddal-rohawala · 2023-12-20T22:16:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 1dd1df4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-20T22:22:56Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 1dd1df4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-20T22:28:15Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 1dd1df4
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-20T22:32:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 1dd1df4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2023-12-20T23:16:53Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1dd1df4
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…-predictor-without-model-id

mufaddal-rohawala · 2024-01-31T23:15:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 7101638
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…ut-model-id

mufaddal-rohawala · 2024-02-01T00:05:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dc245d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T00:23:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dc245d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T00:34:22Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: dc245d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T00:34:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: dc245d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T01:33:03Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: dc245d7
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T01:44:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: dc245d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T02:22:27Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: dc245d7
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T04:04:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T04:35:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T04:36:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 13b7b2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T05:37:50Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 13b7b2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T06:25:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T13:46:42Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T14:19:38Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T14:39:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 13b7b2c
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T17:07:17Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 13b7b2c
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knikure

/bot run local-mode-tests, slow-tests

…ut-model-id

mufaddal-rohawala · 2024-02-01T18:45:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 62a9262
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T18:56:36Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 62a9262
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T19:29:34Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 62a9262
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T19:49:05Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 62a9262
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mufaddal-rohawala · 2024-02-01T20:50:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 62a9262
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

…odel id (infer from tags) (aws#4304) * feat: retrieve jumpstart estimator and predictor without specifying model id (infer from tags) * fix: pylint * chore: add support for ic-based endpoints * chore: update docstrings * chore: add integ tests * chore: add support in conftest for ic endpoints * fix: delete inference components * chore: address tagging and ic determination comments * chore: address PR comments * fix: docstring * chore: improve docs * chore: address comments * fix: list_and_paginate_inference_component_names_associated_with_endpoint in integ test cleanup * fix: boto3 session region * fix: boto_session * fix: sagemaker session to delete IC

feat: retrieve jumpstart estimator and predictor without specifying m…

21177c4

…odel id (infer from tags)

evakravi requested a review from a team as a code owner December 5, 2023 13:37

evakravi requested review from bhupendrasingh and removed request for a team December 5, 2023 13:37

Merge remote-tracking branch 'origin' into feat/retrieve-js-estimator…

8086f6e

…-predictor-without-model-id

fix: pylint

69b2929

JGuinegagne requested changes Dec 5, 2023

View reviewed changes

knikure assigned bhupendrasingh Dec 6, 2023

evakravi added 3 commits December 20, 2023 21:10

chore: add support for ic-based endpoints

3988710

Merge remote-tracking branch 'origin' into feat/retrieve-js-estimator…

c4f7ffc

…-predictor-without-model-id

chore: update docstrings

1dd1df4

evakravi added 2 commits December 21, 2023 18:01

chore: add integ tests

73c17a0

Merge remote-tracking branch 'origin' into feat/retrieve-js-estimator…

a5de8ce

…-predictor-without-model-id

evakravi and others added 2 commits January 31, 2024 23:20

fix: boto_session

254f147

Merge branch 'master' into feat/retrieve-js-estimator-predictor-witho…

dc245d7

…ut-model-id

fix: sagemaker session to delete IC

13b7b2c

knikure reviewed Feb 1, 2024

View reviewed changes

Merge branch 'master' into feat/retrieve-js-estimator-predictor-witho…

62a9262

…ut-model-id

knikure merged commit 5d21a03 into aws:master Feb 1, 2024

feat: retrieve jumpstart estimator and predictor without specifying model id (infer from tags) #4304

feat: retrieve jumpstart estimator and predictor without specifying model id (infer from tags) #4304

Uh oh!

Conversation

evakravi commented Dec 5, 2023

Merge Checklist

General

Tests

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

JGuinegagne left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JGuinegagne Dec 5, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 5, 2023

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Dec 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mufaddal-rohawala commented Dec 20, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 20, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 20, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 20, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Dec 20, 2023

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Jan 31, 2024

AWS CodeBuild CI Report

Uh oh!

mufaddal-rohawala commented Feb 1, 2024

AWS CodeBuild CI Report

Uh oh!

codecov-commenter commented Dec 5, 2023 •

edited

Loading