Add warning if framework_version is not set #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
==========================================
+ Coverage 93.71% 93.75% +0.03%
==========================================
Files 55 55
Lines 4012 4032 +20
==========================================
+ Hits 3760 3780 +20
Misses 252 252
Continue to review full report at Codecov.
|
nadiaya
previously approved these changes
Oct 15, 2018
| UploadedCode = namedtuple('UserCode', ['s3_prefix', 'script_name']) | ||
| """sagemaker.fw_utils.UserCode: An object containing the S3 prefix and script name. | ||
|
|
||
| This is for the source code used for the entry point with an ``Estimator``. It can be | ||
| instantiated with positional or keyword arguments. | ||
| """ | ||
|
|
||
| EMPTY_FRAMEWORK_VERSION_WARNING = 'In an upcoming version of the SageMaker Python SDK, ' \ | ||
| 'framework_version will be required to create an estimator. ' \ | ||
| 'Please add framework_version={} to your constructor to avoid ' \ |
There was a problem hiding this comment.
to the constructor instead of to your constructor?
Doesn't really matter though.
There was a problem hiding this comment.
I think "your" makes it more clear we're referring to the user's code
CHANGELOG.rst
Outdated
| @@ -9,6 +9,7 @@ CHANGELOG | |||
| * feature: Add timestamp to secondary status in training job output | |||
| * bug-fix: Local Mode: Set correct default values for additional_volumes and additional_env_vars | |||
| * enhancement: Local Mode: support nvidia-docker2 natively | |||
| * Frameworks: add warning for upcoming breaking change that makes framework_version required | |||
nadiaya
approved these changes
Oct 15, 2018
pdasamzn
pushed a commit
to pdasamzn/sagemaker-python-sdk
that referenced
this pull request
Nov 1, 2018
In the future, a breaking change will be released that causes framework_version to be required when creating a Framework estimator. This change adds a warning when an estimator is created without framework_version defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In the near future, we will make framework_version a required argument for all framework estimators. This change adds a warning if framework_version is not currently set.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.