Skip to content

change: update readme, trigger p311 tests #4529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

akrishna1995
Copy link
Contributor

@akrishna1995 akrishna1995 commented Mar 25, 2024

Issue #, if available:

Description of changes:

Adding UTs for py311 and official support

Testing done:

run with pytest

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [ x] I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (ca9ae23) to head (6aa3e0d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4529      +/-   ##
==========================================
- Coverage   87.38%   87.38%   -0.01%     
==========================================
  Files         389      389              
  Lines       36776    36776              
==========================================
- Hits        32137    32136       -1     
- Misses       4639     4640       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akrishna1995 akrishna1995 marked this pull request as ready for review March 25, 2024 08:45
@akrishna1995 akrishna1995 requested a review from a team as a code owner March 25, 2024 08:45
@akrishna1995 akrishna1995 requested review from knikure and benieric and removed request for a team and knikure March 25, 2024 08:45
@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 94115ca
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mufaddal-rohawala
Copy link
Member

AWS CodeBuild CI Report

  • CodeBuild project: sagemaker-python-sdk-pr
  • Commit ID: 6aa3e0d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@akrishna1995 akrishna1995 merged commit e163807 into aws:master Mar 25, 2024
@akrishna1995 akrishna1995 deleted the py311-support branch March 25, 2024 18:18
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
* change: update readme, trigger p311 tests

* change: update ci-health checks.yml

* fix: order of py311

---------

Co-authored-by: Ashwin Krishna <[email protected]>
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
* change: update readme, trigger p311 tests

* change: update ci-health checks.yml

* fix: order of py311

---------

Co-authored-by: Ashwin Krishna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants