Skip to content

fix: forward network_isolation parameter to Estimators when False #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

jmahlik
Copy link
Contributor

@jmahlik jmahlik commented Mar 27, 2024

A sagemaker config file would override this parameter if it was True in the config but False in the Estimator parameters.

Closes #4542

Issue #, if available: #4542

Description of changes: Forward the parameter to boto.

Testing done: Manually verified via the logs. I'm not sure where to add a unit test for this. If you can point me to the right spot, happy to add.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmahlik jmahlik requested a review from a team as a code owner March 27, 2024 18:14
@jmahlik jmahlik requested review from akrishna1995 and removed request for a team March 27, 2024 18:14
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.38%. Comparing base (6a38060) to head (6827073).
Report is 6 commits behind head on master.

❗ Current head 6827073 differs from pull request most recent head 04057ff. Consider uploading reports for the commit 04057ff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4543      +/-   ##
==========================================
- Coverage   87.50%   87.38%   -0.12%     
==========================================
  Files         391      389       -2     
  Lines       37098    36779     -319     
==========================================
- Hits        32461    32138     -323     
- Misses       4637     4641       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmahlik
Copy link
Contributor Author

jmahlik commented Mar 27, 2024

Well it turns out this fails something like 500 unit tests that check the args. I think it is a good failure since it confirms the argument is actually being passed. Just need to go through and update all of them.

I just ran a few since there are installation problems with the test requirements on windows.

@jmahlik jmahlik marked this pull request as draft March 27, 2024 19:52
@jmahlik jmahlik force-pushed the estimator-config-network-isolation branch from 6827073 to 621d403 Compare April 9, 2024 22:05
@jmahlik jmahlik temporarily deployed to manual-approval April 9, 2024 22:05 — with GitHub Actions Inactive
@jmahlik
Copy link
Contributor Author

jmahlik commented Apr 9, 2024

I think I fixed them all now. Confirms the kwargs weren't being passed at least. They should be passed in all cases to override the config values when needed.

@jmahlik jmahlik force-pushed the estimator-config-network-isolation branch from 621d403 to 1d6e9b3 Compare April 10, 2024 13:48
@jmahlik jmahlik temporarily deployed to manual-approval April 10, 2024 13:48 — with GitHub Actions Inactive
@jmahlik jmahlik marked this pull request as ready for review April 10, 2024 13:49
A sagemaker config file would override this parameter if it was True in
the config but False in the Estimator parameters.

Closes aws#4542
@jmahlik jmahlik force-pushed the estimator-config-network-isolation branch from 1d6e9b3 to 04057ff Compare April 15, 2024 15:39
@jmahlik jmahlik temporarily deployed to manual-approval April 15, 2024 15:40 — with GitHub Actions Inactive
@jmahlik jmahlik requested a review from akrishna1995 April 15, 2024 15:42
@knikure knikure self-assigned this Apr 16, 2024
@knikure knikure merged commit 2907ea5 into aws:master Apr 16, 2024
@jmahlik jmahlik deleted the estimator-config-network-isolation branch April 16, 2024 21:33
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
…s#4543)

A sagemaker config file would override this parameter if it was True in
the config but False in the Estimator parameters.

Closes aws#4542
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
…s#4543)

A sagemaker config file would override this parameter if it was True in
the config but False in the Estimator parameters.

Closes aws#4542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Estimator.enable_network_isolation parameter ignored by config
3 participants