-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Correctly handle the case where the destination folder does not exist in local mode #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #458 +/- ##
==========================================
- Coverage 94.02% 93.87% -0.16%
==========================================
Files 57 57
Lines 4269 4262 -7
==========================================
- Hits 4014 4001 -13
- Misses 255 261 +6
Continue to review full report at Codecov.
|
Kindly ping @iquintero ? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a changelog entry? And a unit test for this would be nice as well. Otherwise looks good.
This reverts commit 33f37d8.
…eck whether the source dir exists
@iquintero - Thanks for the review. Actually, I've made some updates and used |
@iquintero - Thanks for the approval! Can you also help merge this PR? I don't think I can merge it. :p |
Issue #, if available:
Description of changes:
Right now local mode would break if the
output_path
is afile://
but doesn't exist yet. This PR usesdistutils.dir_util.copy_tree
to handle this.I've verified via a local job that the change fixes the issue.
Previous stack trace:
With this change:
Merge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.