Skip to content

fix: Update Collaborator Check workflow to check for users which are part of collaborator team #4582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

knikure
Copy link
Contributor

@knikure knikure commented Apr 16, 2024

Issue #, if available:

Description of changes:
Collaborator check workflow does not work when member is part of team. e.g., xyz is part of @aws/abc-team but shows as not a collaborator.

Adding correct token with right permissions to check for collaborator who is part of a GitHub team.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@knikure knikure requested a review from a team as a code owner April 16, 2024 17:45
@knikure knikure requested review from zhaoqizqwang and benieric and removed request for a team and zhaoqizqwang April 16, 2024 17:45
@knikure knikure temporarily deployed to manual-approval April 16, 2024 17:45 — with GitHub Actions Inactive
@knikure knikure merged commit 6f36b9c into aws:master Apr 16, 2024
malav-shastri pushed a commit to malav-shastri/sagemaker-python-sdk that referenced this pull request Jun 20, 2024
jiapinw pushed a commit to jiapinw/sagemaker-python-sdk that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants