Add Pylint #465
Merged
Add Pylint #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 94% 94.13% +0.12%
==========================================
Files 57 57
Lines 4284 4259 -25
==========================================
- Hits 4027 4009 -18
+ Misses 257 250 -7
Continue to review full report at Codecov.
|
laurenyu
reviewed
Nov 7, 2018
.pylintrc
Outdated
| signature-differs | ||
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
is the inconsistent number of newlines between sections intentional?
.pylintrc
Outdated
| [TYPECHECK] | ||
| # Tells whether missing members accessed in mixin class should be ignored. A | ||
| # mixin class is detected if its name ends with "mixin" (case insensitive). | ||
| #ignore-mixin-members=yes |
There was a problem hiding this comment.
is it worth keeping around these commented-out config lines?
.pylintrc
Outdated
| #class-rgx=[A-Z_][a-zA-Z0-9]+$ | ||
| # Regular expression which should only match correct function names | ||
| # | ||
| # |
There was a problem hiding this comment.
do we need these empty comment lines?
.pylintrc
Outdated
| [LOGGING] | ||
| # Apply logging string format checks to calls on these modules. | ||
| logging-modules= | ||
| logging |
There was a problem hiding this comment.
add a newline to the end of the file
CHANGELOG.rst
Outdated
| @@ -2,6 +2,10 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| 1.14.1dev | |||
| ========= | |||
| * bug-fix: rename MXNet argument from accelerators -> accelerator | |||
There was a problem hiding this comment.
- add a newline between ll. 6-7
- also don't you mean
distributions->distribution? - does this count as a breaking change?
src/sagemaker/estimator.py
Outdated
| @@ -425,7 +410,7 @@ def _ensure_latest_training_job(self, error_message='Estimator is not associated | |||
|
|
|||
|
|
|||
| class _TrainingJob(_Job): | |||
| def __init__(self, sagemaker_session, training_job_name): | |||
| def __init__(self, sagemaker_session, training_job_name): # pylint: disable=useless-super-delegation | |||
There was a problem hiding this comment.
why is this one important?
laurenyu
reviewed
Nov 8, 2018
.pylintrc
Outdated
| # Maximum number of lines in a module | ||
| #max-module-lines=1000 | ||
| # String used as indentation unit. This is usually " " (4 spaces) or "\t" (1 | ||
| # tab). |
There was a problem hiding this comment.
do we really need to break the line on this comment?
laurenyu
previously approved these changes
Nov 8, 2018
ChoiByungWook
previously approved these changes
Nov 8, 2018
laurenyu
previously approved these changes
Nov 8, 2018
laurenyu
previously approved these changes
Nov 8, 2018
laurenyu
previously approved these changes
Nov 8, 2018
iquintero
changed the title
laurenyu
approved these changes
Nov 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds pylint to the build process - will fail for any Warning/Error on the main codebase. Tests are no included yet.
The handling of the MXNet distribution parameter was being done in Framework instead of MXNet. Pylint flagged this so this PR also fixes that. distributions is now also called distribution which is what was originally intended.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.