Update empty framework_version warning #472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #472 +/- ##
==========================================
+ Coverage 94.04% 94.04% +<.01%
==========================================
Files 57 57
Lines 4263 4268 +5
==========================================
+ Hits 4009 4014 +5
Misses 254 254
Continue to review full report at Codecov.
|
| @@ -232,5 +232,8 @@ def model_code_key_prefix(code_location_key_prefix, model_name, image): | |||
| return '/'.join(filter(None, [code_location_key_prefix, model_name or training_job_name])) | |||
|
|
|||
|
|
|||
| def empty_framework_version_warning(default_version): | |||
| return EMPTY_FRAMEWORK_VERSION_WARNING.format(default_version) | |||
| def empty_framework_version_warning(default_version, latest_version): | |||
icywang86rui
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in accordance with our new strategy around this since we're no longer making
framework_versioncompletely mandatoryMerge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.