Skip to content

change: add JumpStart PDT and OSU regions #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 8, 2024
Merged

change: add JumpStart PDT and OSU regions #4755

merged 2 commits into from
Aug 8, 2024

Conversation

tlian25
Copy link
Contributor

@tlian25 tlian25 commented Jun 24, 2024

Issue #, if available: N/A

Description of changes: add PDT and OSU regions to JumpStart contents as part of region build

Testing done: N/A

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • [x ] I have read the CONTRIBUTING doc
  • [x ] I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • [x ] I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tlian25 tlian25 requested a review from a team as a code owner June 24, 2024 20:39
@tlian25 tlian25 requested a review from nargokul June 24, 2024 20:39
@sage-maker
Copy link
Collaborator

@tlian25
Looks like you have some code styling failures, can you resolve?

@sage-maker
Copy link
Collaborator

Looks like a 503 Sphinx error so I will just rerun the workflow to see if it resolves itself.

@sage-maker sage-maker merged commit 300a2c5 into aws:master Aug 8, 2024
14 checks passed
@tlian25 tlian25 deleted the txlian-fix-branch branch August 15, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants