Skip to content

Fix: Adding application/octet-stream to content type #4772 #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

selvask-aws
Copy link
Collaborator

Issue #, if available:

*Description of changes: Fix for #4772

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@selvask-aws selvask-aws requested a review from a team as a code owner July 10, 2024 19:30
@selvask-aws selvask-aws requested a review from Aditi2424 July 10, 2024 19:30
@Aditi2424 Aditi2424 merged commit fb609f5 into aws:master Jul 12, 2024
11 checks passed
@roshanzameer
Copy link

roshanzameer commented Jul 15, 2024

@Aditi2424 Please create a new release with this fix as this is affecting production workloads.

@mrbrandt92
Copy link

@Aditi2424 - do we have an ETA on when this fix will be packaged into a release? The automated writes from SageMaker local containers -> S3 are writing as application/octet-stream (which we don't have control over in our workflows), and it is impacting production (as @roshanzameer mentioned)

@Aditi2424
Copy link
Contributor

Hello, our weekly release is done on Wednesdays so this change should be released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants