chore: cleanup jumpstart factory #4840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Captainia
reviewed
Aug 16, 2024
Captainia
approved these changes
Aug 19, 2024
akrishna1995
approved these changes
Aug 20, 2024
JGuinegagne
reviewed
Aug 21, 2024
| ) -> dict: | ||
| """Returns a dictionary of model info kwargs to use with JumpStart APIs.""" | ||
|
|
||
| kwargs_dict = { |
There was a problem hiding this comment.
future PRs: consider defining type KwargsType here
| and field | ||
| not in self.SERIALIZATION_EXCLUSION_SET.union(self.BASE_SERIALIZATION_EXCLUSION_SET) | ||
| or not exclude_keys | ||
| ): |
There was a problem hiding this comment.
could you use parenthesis for complex and / or condition & unit test separately please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The factory modules for JumpStart contain a lot of duplicate code, which introduces room for error and reduces code maintainability. In addition, there were places where the model type wasn't being piped to the lower level utilities, which is a result of having messy code. This PR reduces the duplication of the code and also fixes places where the model type wasn't being used. This PR will make it easier in the future to add fields such as
config_name,model_typeand not have to update as many places in the code.Testing done:
Current unit + integ tests pass.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.