Add airflow tuning config export API #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #486 +/- ##
==========================================
+ Coverage 93.82% 93.84% +0.02%
==========================================
Files 58 58
Lines 4323 4355 +32
==========================================
+ Hits 4056 4087 +31
- Misses 267 268 +1
Continue to review full report at Codecov.
|
laurenyu
reviewed
Nov 15, 2018
tests/unit/test_airflow.py
Outdated
| @@ -16,7 +16,7 @@ | |||
| import pytest | |||
| import mock | |||
|
|
|||
| from sagemaker import estimator, tensorflow | |||
| from sagemaker import estimator, tensorflow, mxnet, tuner | |||
There was a problem hiding this comment.
alphabetize the imported modules
tests/unit/test_airflow.py
Outdated
| mxnet_estimator = mxnet.MXNet( | ||
| entry_point="{{ entry_point }}", | ||
| source_dir="{{ source_dir }}", | ||
| py_version='py2', |
There was a problem hiding this comment.
I know it's just a unit test, but it does seem a bit strange to me we're still adding new code that "uses" Python 2
laurenyu
reviewed
Nov 15, 2018
src/sagemaker/workflow/airflow.py
Outdated
| """Export Airflow training config from an estimator | ||
|
|
||
| Args: | ||
| estimator (sagemaker.estimator.EstimatroBase): |
src/sagemaker/workflow/airflow.py
Outdated
| Amazon algorithm. For other estimators, batch size should be specified in the estimator. | ||
|
|
||
| Returns: | ||
| A dict of training config that can be directly used by SageMakerTrainingOperator |
There was a problem hiding this comment.
change this to "dict: training config..."
laurenyu
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.