Skip to content

Make inputs optional for hyperparameter tuning job. #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2018

Conversation

nadiaya
Copy link
Contributor

@nadiaya nadiaya commented Nov 15, 2018

Make inputs optional for hyperparameter tuning job.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nadiaya nadiaya requested a review from laurenyu November 15, 2018 22:57
@codecov-io
Copy link

codecov-io commented Nov 15, 2018

Codecov Report

Merging #490 into master will decrease coverage by 0.02%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #490      +/-   ##
==========================================
- Coverage   93.98%   93.96%   -0.03%     
==========================================
  Files          58       58              
  Lines        4355     4357       +2     
==========================================
+ Hits         4093     4094       +1     
- Misses        262      263       +1
Impacted Files Coverage Δ
src/sagemaker/session.py 89.78% <0%> (-0.44%) ⬇️
src/sagemaker/tuner.py 97.25% <100%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 501eced...f37cb28. Read the comment docs.

jesterhazy
jesterhazy previously approved these changes Nov 15, 2018
laurenyu
laurenyu previously approved these changes Nov 16, 2018
@laurenyu laurenyu merged commit faccfb2 into aws:master Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants