Add warning about not supporting torch.nn.SyncBatchNorm #5046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
nargokul
reviewed
Feb 18, 2025
Comment on lines
378
to
379
| Warning: ``torch.nn.SyncBatchNorm`` is not supported and its existence in | ||
| ``init_process_group`` will cause an exception during distributed training. |
There was a problem hiding this comment.
Can we make the wording more generic instead of just this use case ?
smdistributed with init_process_group will not allow use of certain other torch features, such as (and likely not limited to) torch.nn.SyncBatchNorm.
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
pintaoz-aws
temporarily deployed
to
auto-approve
GitHub Actions
Inactive
chad119
approved these changes
Feb 18, 2025
evakravi
pushed a commit
to evakravi/sagemaker-python-sdk
that referenced
this pull request
Mar 20, 2025
* Add warning about not supporting * update wording --------- Co-authored-by: pintaoz <[email protected]>
pravali96
pushed a commit
to pravali96/sagemaker-python-sdk
that referenced
this pull request
Apr 21, 2025
* Add warning about not supporting * update wording --------- Co-authored-by: pintaoz <[email protected]>
uyoldas
pushed a commit
to uyoldas/sagemaker-python-sdk
that referenced
this pull request
May 23, 2025
* Add warning about not supporting * update wording --------- Co-authored-by: pintaoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#2571
Description of changes:
Add warning about not supporting torch.nn.SyncBatchNorm
Testing done:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_baseto create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.