Skip to content

Update instance gpu info #5119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2025
Merged

Update instance gpu info #5119

merged 1 commit into from
Apr 5, 2025

Conversation

ruiliann666
Copy link
Contributor

@ruiliann666 ruiliann666 commented Apr 4, 2025

Issue #, if available:
Tests failed due to ec2 update instance gpu info.

__________________________ test_get_gpu_info_success ___________________________
[gw42] linux -- Python 3.10.13 /codebuild/output/src4177795889/src/github.com/aws/sagemaker-python-sdk/.tox/py310/bin/python

sagemaker_session = <sagemaker.session.Session object at 0x7f0e61a990f0>

    def test_get_gpu_info_success(sagemaker_session):
        gpu_info = hardware_detector._get_gpu_info(VALID_INSTANCE_TYPE, sagemaker_session)

>       assert gpu_info == EXPECTED_INSTANCE_GPU_INFO
E       assert (8, 183104) == (8, 196608)
E         At index 1 diff: 183104 != 196608
E         Full diff:
E         - (8, 196608)
E         + (8, 183104)

tests/integ/sagemaker/serve/utils/test_hardware_detector.py:28: AssertionError
----------------------------- Captured stderr call -----------------------------
ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)
----------------------------- Captured stderr call -----------------------------
ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)
----------------------------- Captured stderr call -----------------------------
ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)
----------------------------- Captured stderr call -----------------------------
ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)

Description of changes:

Update the hardcoded value.

Verified by running:

➜ aws ec2 describe-instance-types \
  --instance-types g5.48xlarge \
  --region us-east-1 \
  --query "InstanceTypes[].{
    InstanceType: InstanceType,
    TotalGpuMemoryInMiB: GpuInfo.TotalGpuMemoryInMiB,
    GpuCount: GpuInfo.Gpus[].Count | [0]
  }"

Response:

[
    {
        "InstanceType": "g5.48xlarge",
        "TotalGpuMemoryInMiB": 183104,
        "GpuCount": 8
    }
]

Testing done:

Local ran unit and integ tests.

../../../../../home/ruiliann/MorpheusMaster/sagemaker-python-sdk/tests/integ/sagemaker/serve/utils/test_hardware_detector.py::test_get_gpu_info_success [04/04/25 17:25:30] INFO     Found credentials in shared credentials file: ~/.aws/credentials                                                        credentials.py:1352
ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)
PASSED
../../../../../home/ruiliann/MorpheusMaster/sagemaker-python-sdk/tests/integ/sagemaker/serve/utils/test_hardware_detector.py::test_get_gpu_info_throws PASSED
../../../../../home/ruiliann/MorpheusMaster/sagemaker-python-sdk/tests/integ/sagemaker/serve/utils/test_hardware_detector.py::test_get_gpu_info_fallback_success ModelBuilder: INFO:     GPU Info [g5.48xlarge]: (8, 183104)
PASSED
../../../../../home/ruiliann/MorpheusMaster/sagemaker-python-sdk/tests/integ/sagemaker/serve/utils/test_hardware_detector.py::test_get_gpu_info_fallback_throws PASSED

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ruiliann666 ruiliann666 requested a review from a team as a code owner April 4, 2025 17:31
@ruiliann666 ruiliann666 requested a review from pintaoz-aws April 4, 2025 17:31
@benieric benieric merged commit 0a86e60 into aws:master Apr 5, 2025
14 checks passed
mollyheamazon pushed a commit that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants