Skip to content

Fix: fix the issue due to PR changes, 5122 #5124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Apr 15, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
25f16ef
change: Allow telemetry only in supported regions
Jan 29, 2025
0ed85d6
change: Allow telemetry only in supported regions
Jan 29, 2025
b69ffcb
change: Allow telemetry only in supported regions
Jan 29, 2025
8d7f4a8
change: Allow telemetry only in supported regions
Jan 29, 2025
9321367
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Jan 29, 2025
f972222
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Jan 30, 2025
dadbb22
change: Allow telemetry only in supported regions
Jan 30, 2025
28b3fe8
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Feb 23, 2025
fe64f82
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Feb 24, 2025
7775c63
documentation: Removed a line about python version requirements of tr…
Feb 24, 2025
acc861a
Merge branch 'master' into rsareddy-dev
rsareddy0329 Feb 24, 2025
16dc02b
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 10, 2025
06597c6
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 11, 2025
249872d
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 12, 2025
58f8746
feature: Enabled update_endpoint through model_builder
Mar 12, 2025
c6bad70
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 12, 2025
0bf6404
fix: fix unit test, black-check, pylint errors
Mar 12, 2025
c67d7df
fix: fix black-check, pylint errors
Mar 12, 2025
1f84662
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 13, 2025
ea1810b
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 14, 2025
6079269
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 14, 2025
c9fcefb
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Mar 17, 2025
16b6f0c
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Apr 8, 2025
89e18a9
fix:Added handler for pipeline variable while creating process job
Apr 8, 2025
10d4c4f
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Apr 9, 2025
7f15e19
fix: Added handler for pipeline variable while creating process job
Apr 9, 2025
7440f4d
Merge branch 'aws:master' into rsareddy-dev
rsareddy0329 Apr 14, 2025
de11c91
Revert the PR changes: #5122, due to issue https://t.corp.amazon.com/…
Apr 14, 2025
7acccdb
Fix: fix the issue, https://t.corp.amazon.com/P223568185/communication
Apr 14, 2025
89c2b27
Merge branch 'master' into rsareddy-dev
rsareddy0329 Apr 15, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sagemaker/processing.py
Original file line number Diff line number Diff line change
Expand Up @@ -314,14 +314,15 @@ def _normalize_args(
"code argument has to be a valid S3 URI or local file path "
+ "rather than a pipeline variable"
)

if arguments is not None:
processed_arguments = []
for arg in arguments:
if isinstance(arg, PipelineVariable):
processed_value = json.dumps(arg.expr)
processed_arguments.append(processed_value)
else:
processed_arguments.append(str(arg))
processed_arguments.append(arg)
arguments = processed_arguments

self._current_job_name = self._generate_current_job_name(job_name=job_name)
Expand Down
3 changes: 3 additions & 0 deletions tests/unit/sagemaker/workflow/test_processing_step.py
Original file line number Diff line number Diff line change
Expand Up @@ -824,12 +824,14 @@ def test_spark_processor(spark_processor, processing_input, pipeline_session):
processor, run_inputs = spark_processor
processor.sagemaker_session = pipeline_session
processor.role = ROLE

arguments_output = [
"--input",
"input-data-uri",
"--output",
'{"Get": "Parameters.MyArgOutput"}',
]

run_inputs["inputs"] = processing_input

step_args = processor.run(**run_inputs)
Expand Down Expand Up @@ -1024,6 +1026,7 @@ def test_spark_processor_local_code(spark_processor, processing_input, pipeline_
processor, run_inputs = spark_processor
processor.sagemaker_session = pipeline_session
processor.role = ROLE

arguments_output = [
"--input",
"input-data-uri",
Expand Down