Skip to content

Add API doc for Airflow #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2018
Merged

Add API doc for Airflow #543

merged 2 commits into from
Dec 10, 2018

Conversation

yangaws
Copy link
Contributor

@yangaws yangaws commented Dec 10, 2018

Issue #, if available:

Description of changes:

  1. Add API doc for Airflow
  2. Fix API doc for RL

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yangaws yangaws requested review from laurenyu and nadiaya December 10, 2018 22:26
doc/index.rst Outdated
@@ -62,3 +62,12 @@ Amazon provides implementations of some common machine learning algortithms opti
factorization_machines
lda
ntm

SageMaker Workflow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it make more sense to change this to just "Workflows"? (the workflow tools themselves aren't part of SageMaker)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is better.

Updated! Thanks!

@codecov-io
Copy link

codecov-io commented Dec 10, 2018

Codecov Report

Merging #543 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #543   +/-   ##
=======================================
  Coverage   92.77%   92.77%           
=======================================
  Files          71       71           
  Lines        5357     5357           
=======================================
  Hits         4970     4970           
  Misses        387      387

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bffdbff...f38f4d9. Read the comment docs.

doc/index.rst Outdated

SageMaker Workflow
------------------
SageMaker APIs to export configurations to create and manage Airflow workflows.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/to create and manage/for creating and managing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@nadiaya nadiaya merged commit 6555f09 into aws:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants