Skip to content

Add TFRecord split type to docs #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 24, 2018
Merged

Add TFRecord split type to docs #577

merged 3 commits into from
Dec 24, 2018

Conversation

apacker
Copy link
Contributor

@apacker apacker commented Dec 21, 2018

Issue #, if available: N/A

Description of changes: Adds TFRecord split type to doc strings where applicable

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #577 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #577   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files          71       71           
  Lines        5367     5367           
=======================================
  Hits         4980     4980           
  Misses        387      387
Impacted Files Coverage Δ
src/sagemaker/workflow/airflow.py 92.22% <ø> (ø) ⬆️
src/sagemaker/transformer.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed40f13...d34859e. Read the comment docs.

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. do you mind adding a doc-fix entry in the changelog for this?

Copy link
Contributor

@laurenyu laurenyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a couple PRs that look good other than missing a changelog entry, so I'll go ahead and merge this first.

@laurenyu laurenyu merged commit f32a441 into aws:master Dec 24, 2018
@laurenyu laurenyu mentioned this pull request Dec 24, 2018
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants