Reducing test flakiness #601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icywang86rui
previously approved these changes
Jan 16, 2019
mvsusp
changed the title
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 92.69% 92.69%
=======================================
Files 71 71
Lines 5405 5405
=======================================
Hits 5010 5010
Misses 395 395Continue to review full report at Codecov.
|
iquintero
reviewed
Jan 17, 2019
| Returns: | ||
|
|
||
| """ | ||
| os.system('docker network create sagemaker-local') |
There was a problem hiding this comment.
how is this 'if necessary' ?
shouldnt this method be renamed to create_sagemaker_local_network() ?
iquintero
approved these changes
Jan 17, 2019
| def create_sagemaker_local_network(): | ||
| """ | ||
| Docker has a known race condition which allows two parallel processes | ||
| to create a duplicated networks with the same name. This function |
There was a problem hiding this comment.
s/to create a duplicated/to create duplicated
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.