Skip to content

Bumping up version to 1.18.0 for horovod release #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

uditbhatia
Copy link
Contributor

Issue #, if available:

Description of changes:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@uditbhatia uditbhatia requested a review from nadiaya January 17, 2019 04:28
1.18.0
======

* feature: Support for Horovod

1.17.3
======

* bug-fix: Handle StopIteration in CloudWatch Logs retrieval
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we release 1.17.3? If not these should be under 1.18.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I removed 1.17.3 from changelog

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #604 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #604   +/-   ##
======================================
  Coverage    92.7%   92.7%           
======================================
  Files          71      71           
  Lines        5418    5418           
======================================
  Hits         5023    5023           
  Misses        395     395
Impacted Files Coverage Δ
src/sagemaker/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a61a7c...eab2203. Read the comment docs.

@uditbhatia uditbhatia merged commit 84a849f into aws:master Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants