Skip to content

configure for codebuild pr builds #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2019
Merged

configure for codebuild pr builds #679

merged 3 commits into from
Mar 3, 2019

Conversation

jesterhazy
Copy link
Contributor

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated the changelog with a description of my changes (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jesterhazy jesterhazy requested review from iquintero and nadiaya March 2, 2019 08:26
nadiaya
nadiaya previously approved these changes Mar 2, 2019
Copy link
Contributor

@nadiaya nadiaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@jesterhazy
Copy link
Contributor Author

do not merge until the backend codebuild changes are deployed.

@jesterhazy
Copy link
Contributor Author

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor Author

AWS CodeBuild CI Report

  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor Author

overriding test failures - one is transient tf segfault, two are permissions errors on a kms key (fixed in iam).

@jesterhazy jesterhazy merged commit 851e51a into aws:master Mar 3, 2019
@jesterhazy jesterhazy deleted the cb branch March 3, 2019 00:52
@laurenyu laurenyu mentioned this pull request Mar 3, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants