Skip to content

fix: skip p2 test of tf script mode in regions without p2 instances #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 23, 2019
Merged

fix: skip p2 test of tf script mode in regions without p2 instances #760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5620eb8
fix: skip p2 test of tf script mode in regions without p2 instances
yangaws Apr 22, 2019
f28cb2f
Freeze urllib3 version to avoid conflicts
yangaws Apr 22, 2019
625e878
Fix urllib3 version
yangaws Apr 22, 2019
10c746f
Specify allow_pickle=True in npy serializer object test
yangaws Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ def read_version():

# Declare minimal set for installation
required_packages = ['boto3>=1.9.64', 'numpy>=1.9.0', 'protobuf>=3.1', 'scipy>=0.19.0',
'urllib3>=1.21', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.23.0',
'urllib3>=1.21, <1.25', 'protobuf3-to-dict>=0.1.5', 'docker-compose>=1.23.0',
'requests>=2.20.0, <2.21']

# enum is introduced in Python 3.4. Installing enum back port
Expand Down
2 changes: 2 additions & 0 deletions tests/integ/test_tf_script_mode.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ def instance_type(request):
return request.param


@pytest.mark.skipif(integ.test_region() in integ.HOSTING_NO_P2_REGIONS,
reason='no ml.p2 instances in these regions')
@pytest.mark.skipif(integ.PYTHON_VERSION != 'py3', reason="Script Mode tests are only configured to run with Python 3")
def test_mnist(sagemaker_session, instance_type):
estimator = TensorFlow(entry_point=SCRIPT,
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/test_predictor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ def test_npy_serializer_object():

result = npy_serializer(object)

assert np.array_equal(np.array(object), np.load(io.BytesIO(result)))
assert np.array_equal(np.array(object), np.load(io.BytesIO(result), allow_pickle=True))


def test_npy_serializer_list_of_empty():
Expand Down