change: add KMS key option for Endpoint Configs #762
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
src/sagemaker/model.py
Outdated
| @@ -235,6 +235,8 @@ def deploy(self, initial_instance_count, instance_type, accelerator_type=None, e | |||
| If True, this will deploy a new EndpointConfig to an already existing endpoint and delete resources | |||
| corresponding to the previous EndpointConfig. If False, a new endpoint will be created. Default: False | |||
| tags(List[dict[str, str]]): The list of tags to attach to this specific endpoint. | |||
| kms_key (str): The KMS key that is used to encrypt the data on the storage volume attached | |||
There was a problem hiding this comment.
Let's make it clear that this is the arn of the kms_key
tests/integ/test_mxnet_train.py
Outdated
| sts_client = sagemaker_session.boto_session.client('sts') | ||
| account_id = sts_client.get_caller_identity()['Account'] | ||
| kms_client = sagemaker_session.boto_session.client('kms') | ||
| kms_key_arn = get_or_create_kms_key(kms_client, account_id) |
There was a problem hiding this comment.
Optional - I think it will make this code cleaner if get_or_create_kms_key just take sageamker_session as the argument.
tests/integ/test_mxnet_train.py
Outdated
| @@ -109,6 +110,30 @@ def test_deploy_model_with_tags(mxnet_training_job, sagemaker_session, mxnet_ful | |||
| assert production_variants[0]['InitialInstanceCount'] == 1 | |||
|
|
|||
|
|
|||
| def test_deploy_model_with_kms_key(mxnet_training_job, sagemaker_session, mxnet_full_version): | |||
There was a problem hiding this comment.
Should we just add this to an existing test? They are already taking so long to run use so much resource.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change exposes the option of using a KMS key to encrypt the instance hosting a SageMaker Endpoint.
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.