Skip to content

change: enable wrong-import-order Pylint check #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ disable=
import-error, # Since we run Pylint before any of our builds in tox, this will always fail
protected-access, # TODO: Fix access
abstract-method, # TODO: Fix abstract methods
wrong-import-order, # TODO: Fix import order
useless-object-inheritance, # TODO: Remove unnecessary imports
cyclic-import, # TODO: Resolve cyclic imports
no-self-use, # TODO: Convert methods to functions where appropriate
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/fw_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@

import os
import re
import sagemaker.utils
import shutil
import tempfile
from six.moves.urllib.parse import urlparse

import sagemaker.utils
from sagemaker.utils import get_ecr_image_uri_prefix, ECR_URI_PATTERN

_TAR_SOURCE_FILENAME = "source.tar.gz"
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/git_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@
from __future__ import absolute_import

import os
import six
import subprocess
import tempfile
import warnings
import six
from six.moves import urllib


Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/local/image.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,8 @@
import tarfile
import tempfile

from six.moves.urllib.parse import urlparse
from threading import Thread
from six.moves.urllib.parse import urlparse

import yaml

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/predictor.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
import codecs
import csv
import json
import numpy as np
import six
from six import StringIO, BytesIO
import numpy as np

from sagemaker.content_types import CONTENT_TYPE_JSON, CONTENT_TYPE_CSV, CONTENT_TYPE_NPY
from sagemaker.session import Session
Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import time
import warnings

import six
import boto3
import botocore.config
import six
import yaml
from botocore.exceptions import ClientError

Expand Down
2 changes: 1 addition & 1 deletion src/sagemaker/user_agent.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
# language governing permissions and limitations under the License.
from __future__ import absolute_import

import pkg_resources
import platform
import sys
import pkg_resources

import boto3
import botocore
Expand Down