Local mode support for Generic Estimators #94
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvsusp
changed the title
apacker
pushed a commit
to apacker/sagemaker-python-sdk
that referenced
this pull request
Nov 15, 2018
updating the python environment for XGBoost notebooks as per the feed…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @iquintero,
I made some changes in the
class Estimatorto be compatible with local mode.My use case was:
The main difference is that Estimator's parent class is EstimatorBase instead of Framework. The hyperparameters were not working for the class as well.
I put these things in PR so you can evaluate the changes I've made. You probably will want to use them.
I'm removing the Keras estimators from this branch as well.