Skip to content

rework CONTRIBUTING.md to include a development workflow #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2019
Merged

rework CONTRIBUTING.md to include a development workflow #973

merged 4 commits into from
Aug 8, 2019

Conversation

knakad
Copy link
Contributor

@knakad knakad commented Aug 8, 2019

This commit covers adding a development workflow to ease
contributions.

This commit also includes:

  • Refactoring/formatting.
  • Adding a Table of Contents.
  • Capitalization changes.
  • Consistency changes.
  • Updating PULL_REQUEST_TEMPLATE to reflect changes.

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

  • I have read the CONTRIBUTING doc
  • I used the commit message format described in CONTRIBUTING
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have updated any necessary documentation (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

knakad added 3 commits August 8, 2019 14:33
@knakad
doc: rework CONTRIBUTING.md to include a development workflow
c1d0768 
This commit covers adding a development workflow to ease
contributions.

This commit also includes:
* Refactoring/formatting.
* Adding a Table of Contents.
* Capitalization changes.
* Consistency changes.
@knakad
doc: update PULL_REQUEST_TEMPLATE.md to reflect recent changes
dc6e749
@knakad
doc: update PULL_REQUEST_TEMPLATE.md to reflect recent changes. Take 2
1203353
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

knakad
knakad commented Aug 8, 2019
View reviewed changes
CONTRIBUTING.md
@@ -81,34 +119,43 @@ documentation: add MXNet documentation
Valid prefixes are listed in the table below.

| Prefix | Use for... |
|-----------------|------------------------------------------------------------------------------------------------|
|----------------:|:-----------------------------------------------------------------------------------------------|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aligns text in first column to the right.
Aligns text in second column to the left.

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knakad knakad requested review from eslesar-aws and mvsusp August 8, 2019 22:05
@jesterhazy
Copy link
Contributor

AWS CodeBuild CI Report

  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@knakad knakad merged commit c38829e into aws:master Aug 8, 2019
@knakad knakad deleted the 20190808-contributing-unsnarling branch August 12, 2019 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvsusp mvsusp mvsusp approved these changes

@eslesar-aws eslesar-aws Awaiting requested review from eslesar-aws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knakad @jesterhazy @mvsusp