Skip to content

change: add 1p algorithm support for me-south-1 #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2019
Merged

change: add 1p algorithm support for me-south-1 #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd31218
change: add 1p algorithm support for me-south-1
Oct 21, 2019
98af48b
fix typo
Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions ...rc/main/scala/com/amazonaws/services/sagemaker/sparksdk/algorithms/ImageURIProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,9 @@ private[algorithms] object SagerMakerRegionAccountMaps {
Regions.AP_EAST_1.getName -> "286214385809",
Regions.SA_EAST_1.getName -> "855470959533",
Regions.EU_NORTH_1.getName -> "669576153137",
Regions.EU_WEST_3.getName -> "749696950732"
Regions.EU_WEST_3.getName -> "749696950732",
Regions.EU_WEST_3.getName -> "749696950732",
Regions.ME_SOUTH_1.getName -> "249704162688"
)

// For LDA
Expand Down Expand Up @@ -90,7 +92,9 @@ private[algorithms] object SagerMakerRegionAccountMaps {
Regions.AP_EAST_1.getName -> "286214385809",
Regions.SA_EAST_1.getName -> "855470959533",
Regions.EU_NORTH_1.getName -> "669576153137",
Regions.EU_WEST_3.getName -> "749696950732"
Regions.EU_WEST_3.getName -> "749696950732",
Regions.EU_WEST_3.getName -> "749696950732",
Regions.ME_SOUTH_1.getName -> "249704162688"
)
}

10 changes: 10 additions & 0 deletions ...services/sagemaker/sparksdk/algorithms/FactorizationMachinesSageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,11 @@ class FactorizationMachinesSageMakerEstimatorTests extends FlatSpec with Mockito
createFactorizationMachinesBinaryClassifier(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/factorization-machines:1")

val estimatorMESouth1 =
createFactorizationMachinesBinaryClassifier(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/factorization-machines:1")
}

it should "use the correct defaults for regressor" in {
Expand Down Expand Up @@ -243,6 +248,11 @@ class FactorizationMachinesSageMakerEstimatorTests extends FlatSpec with Mockito
createFactorizationMachinesRegressor(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/factorization-machines:1")

val estimatorMESouth1 =
createFactorizationMachinesRegressor(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/factorization-machines:1")
}

it should "setFeatureDim" in {
Expand Down
4 changes: 4 additions & 0 deletions .../com/amazonaws/services/sagemaker/sparksdk/algorithms/KMeansSageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,10 @@ class KMeansSageMakerEstimatorTests extends FlatSpec with Matchers with MockitoS
val estimatorEUWest3 = createKMeansEstimator(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/kmeans:1")

val estimatorMESouth1 = createKMeansEstimator(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/kmeans:1")
}

it should "setK" in {
Expand Down
15 changes: 15 additions & 0 deletions ...azonaws/services/sagemaker/sparksdk/algorithms/LinearLearnerSageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,11 @@ class LinearLearnerSageMakerEstimatorTests extends FlatSpec with MockitoSugar {
createLinearLearnerBinaryClassifier(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/linear-learner:1")

val estimatorMESouth1 =
createLinearLearnerBinaryClassifier(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/linear-learner:1")
}

it should "use the correct defaults for multiclass classifier" in {
Expand Down Expand Up @@ -251,6 +256,11 @@ class LinearLearnerSageMakerEstimatorTests extends FlatSpec with MockitoSugar {
createLinearLearnerMultiClassClassifier(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/linear-learner:1")

val estimatorMESouth1 =
createLinearLearnerMultiClassClassifier(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/linear-learner:1")
}

it should "use the correct defaults for regressor" in {
Expand Down Expand Up @@ -347,6 +357,11 @@ class LinearLearnerSageMakerEstimatorTests extends FlatSpec with MockitoSugar {
createLinearLearnerRegressor(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/linear-learner:1")

val estimatorMESouth1 =
createLinearLearnerRegressor(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/linear-learner:1")
}

it should "setFeatureDim" in {
Expand Down
4 changes: 4 additions & 0 deletions ...ala/com/amazonaws/services/sagemaker/sparksdk/algorithms/PCASageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ class PCASageMakerEstimatorTests extends FlatSpec with MockitoSugar {
val estimatorEUWest3 = createPCAEstimator(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/pca:1")

val estimatorMESouth1 = createPCAEstimator(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/pca:1")
}

it should "use the correct defaults" in {
Expand Down
4 changes: 4 additions & 0 deletions ...com/amazonaws/services/sagemaker/sparksdk/algorithms/XGBoostSageMakerEstimatorTests.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,10 @@ class XGBoostSageMakerEstimatorTests extends FlatSpec with Matchers with Mockito
val estimatorEUWest3 = createXGBoostEstimator(region = Regions.EU_WEST_3.getName)
assert(estimatorEUWest3.trainingImage ==
"749696950732.dkr.ecr.eu-west-3.amazonaws.com/xgboost:1")

val estimatorMESouth1 = createXGBoostEstimator(region = Regions.ME_SOUTH_1.getName)
assert(estimatorMESouth1.trainingImage ==
"249704162688.dkr.ecr.me-south-1.amazonaws.com/xgboost:1")
}

it should "setBooster" in {
Expand Down