This repository was archived by the owner on May 23, 2024. It is now read-only.
simplify tfs versioning #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
approved these changes
Feb 18, 2019
| FROM tensorflow/serving:1.11.1 as tfs | ||
| ARG TFS_VERSION | ||
|
|
||
| FROM tensorflow/serving:${TFS_VERSION} as tfs |
There was a problem hiding this comment.
There doesn't exist a base EI binary image.
Right now EI handles installation by copying the binary over from the local host.
The COPY --from doesn't get interpreted properly by Docker for local files. We would probably have to introduce a new arg?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.