This repository was archived by the owner on May 23, 2024. It is now read-only.
pin versions of all python dependencies #56
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jesterhazy
reviewed
Jun 20, 2019
docker/1.13/Dockerfile.cpu
Outdated
| @@ -41,7 +41,7 @@ ENV PYTHONDONTWRITEBYTECODE=1 PYTHONUNBUFFERED=1 | |||
|
|
|||
| # cython, falcon, gunicorn | |||
| RUN \ | |||
| ${PIP} install cython falcon gunicorn gevent requests | |||
| ${PIP} install cython==0.29.10 falcon==2.0.0 gunicorn==19.9.0 gevent==1.4.0 requests==2.22.0 | |||
There was a problem hiding this comment.
- why only for 1.13?
- why divergent pip args for cpu and gpu?
- what about ei?
There was a problem hiding this comment.
Pinning version is a requirement for the asimov containers. only 1.13 tfs containers are merged with the asimov dependencies. The discrepancies of dependencies are from the asimov side.
There was a problem hiding this comment.
The requests version for the rest of the Python3 Docker files are pinned to 2.21.0. Are we sure we want to pin the version here to be 2.22.0?
Richardwan7
approved these changes
Jun 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.