Set S3 environment variables #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvsusp
approved these changes
Nov 15, 2018
| import subprocess | ||
| import time | ||
|
|
||
| import sagemaker_containers.beta.framework as framework | ||
|
|
||
| import sagemaker_tensorflow_container.s3_utils as s3_utils |
There was a problem hiding this comment.
You can just do:
from sagemaker_tensorflow_container import s3_utils| @@ -151,5 +154,6 @@ def main(): | |||
| """ | |||
| hyperparameters = framework.env.read_hyperparameters() | |||
| env = framework.training_env(hyperparameters=hyperparameters) | |||
| s3_utils.configure_s3_env(env.hyperparameters['model_dir'], os.environ['SAGEMAKER_REGION']) | |||
There was a problem hiding this comment.
nit: based on Python pep8 conventions https://www.python.org/dev/peps/pep-0008/#naming-conventions
s3_utils.configure_s3_env sounds repetitive, some options could be:
- s3.configure
- s3.configure_env
- s3.configure_env_vars
- s3_utils.configure
...
Consider both the module and the function together for naming.
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Setting S3 environment variables before training starts * Remove S3 environment variable setting in test training script * Add unit tests
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Setting S3 environment variables before training starts * Remove S3 environment variable setting in test training script * Add unit tests
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Setting S3 environment variables before training starts * Remove S3 environment variable setting in test training script * Add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.