Create parameter server in different thread #127
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icywang86rui
suggested changes
Nov 26, 2018
test/unit/test_training.py
Outdated
| @@ -83,73 +84,58 @@ def test_single_machine(run_module, single_machine_training_env): | |||
| single_machine_training_env.to_env_vars()) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.version_info.major != 3, | |||
There was a problem hiding this comment.
This tests are flaky on py2 because of the dict key ordering. I think we should add the skipif back.
| env.to_cmd_args(), env_vars, wait=False) | ||
| logger.info('Running distributed training job with parameter servers') | ||
|
|
||
| tf_config = _build_tf_config(hosts=env.hosts, current_host=env.current_host) |
There was a problem hiding this comment.
should we just remove the ps_task parameter in _build_tf_config? It's not used anymore. Not critical. if you don't want to fiddle with the unit tests we can do it later.
icywang86rui
approved these changes
Nov 26, 2018
icywang86rui
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.