Fix broken test test_distributed_mnist_no_ps #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test shouldn't save checkpoints since the two hosts are justing running training jobs independently. The checkpoints interfere with each other. Changing the test to use the Keras mnist script here. This change also changed the saved model path to /opt/ml/opt so we can just use the estimator.model_data path to assert the model exists.
yangaws
approved these changes
Jan 28, 2019
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
This test shouldn't save checkpoints since the two hosts are justing running training jobs independently. The checkpoints interfere with each other. Changing the test to use the Keras mnist script here. This change also changed the saved model path to /opt/ml/opt so we can just use the estimator.model_data path to assert the model exists.
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
This test shouldn't save checkpoints since the two hosts are justing running training jobs independently. The checkpoints interfere with each other. Changing the test to use the Keras mnist script here. This change also changed the saved model path to /opt/ml/opt so we can just use the estimator.model_data path to assert the model exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test shouldn't save checkpoints since the two hosts are justing running
training jobs independently. The checkpoints interfere with each other. Changing
the test to use the Keras mnist script here.
This change also changed the saved model path to /opt/ml/opt so we can just use
the estimator.model_data path to assert the model exists.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.