Skip to content

Tune test_s3_plugin test #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Tune test_s3_plugin test #178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9d48fd
Tune test_s3_plug_in test
icywang86rui Apr 3, 2019
927e619
Fix flake8 error
icywang86rui Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions test/integration/sagemaker/test_mnist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import os

import boto3
import pytest
from sagemaker.tensorflow import TensorFlow
from six.moves.urllib.parse import urlparse

Expand Down Expand Up @@ -81,23 +80,21 @@ def test_distributed_mnist_ps(sagemaker_session, ecr_image, instance_type, frame
_assert_s3_file_exists(sagemaker_session.boto_region_name, estimator.model_data)


# TODO: Enable this test when new binary fixing the s3 plugin released
@pytest.mark.skip(reason='Skip the test until new binary released')
def test_s3_plugin(sagemaker_session, ecr_image, instance_type, region, framework_version):
resource_path = os.path.join(os.path.dirname(__file__), '..', '..', 'resources')
script = os.path.join(resource_path, 'mnist', 'mnist_estimator.py')
estimator = TensorFlow(entry_point=script,
role='SageMakerRole',
hyperparameters={
# Saving a checkpoint after every step to hammer the S3 plugin
'save-checkpoint-steps': 1,
# Saving a checkpoint after every 5 steps to hammer the S3 plugin
'save-checkpoint-steps': 10,
# Disable throttling for checkpoint and model saving
'throttle-secs': 0,
# Without the patch training jobs would fail around 100th to
# 150th step
'max-steps': 200,
# Large batch size would result in a larger checkpoint file
'batch-size': 2048,
'batch-size': 1024,
# This makes the training job exporting model during training.
# Stale model garbage collection will also be performed.
'export-model-during-training': True
Expand Down