Add mpi4py to pip installs #185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
mvsusp
approved these changes
Apr 30, 2019
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
corresponds to aws/sagemaker-containers#191
Description of changes:
MPI may fail to detect process failure, which can cause a process to hang. mpi4py forces all processes to abort if an uncaught exception occurs. See https://docs.chainer.org/en/stable/chainermn/tutorial/tips_faqs.html#mpi-process-hangs-after-an-unhandled-python-exception (though the link is related to Chainer, it says that the problem is not specific to ChainerNM).
I tested locally (so CPU only) with the related SageMaker Containers change to ensure that Horovod should still work, including checking the assert statement mentioned in https://github.com/horovod/horovod#mpi4py.
edit: not sure why the CodeBuild run is still showing as a failure; I restarted it (failure was due to a tuning job name collision) and it passed: https://us-west-2.console.aws.amazon.com/codesuite/codebuild/projects/sagemaker-tensorflow-container-integ-p36-gpu/build/sagemaker-tensorflow-container-integ-p36-gpu%3A194011a1-f1c0-4135-8530-58f734484084/log
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.