Update integ test for checking Python version #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icywang86rui
reviewed
May 8, 2019
|
|
||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('--output-dir', default=os.environ['SM_OUTPUT_DIR']) | ||
| parser.add_argument('--model_dir') |
There was a problem hiding this comment.
you are not using --model_dir so you can just use parser.parse_known_args.
There was a problem hiding this comment.
actually you don't need to parse the args at all here. Just use SM_OUTPUT_DIR directly.
icywang86rui
approved these changes
May 13, 2019
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Update integ test for checking Python version * remove emacs backup file * remove extraneous code * Python 2 compatibility
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Update integ test for checking Python version * remove emacs backup file * remove extraneous code * Python 2 compatibility
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Update integ test for checking Python version * remove emacs backup file * remove extraneous code * Python 2 compatibility
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Updating one last test (hopefully) to use the SageMaker Python SDK's Local Mode
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.