Add release build #191
Merged
Add release build #191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
reviewed
May 20, 2019
buildspec-release.yml
Outdated
| - tox -e flake8 | ||
|
|
||
| # run unit tests | ||
| - tox -e py36 test/unit |
buildspec.yml
Outdated
| @@ -97,15 +97,15 @@ phases: | |||
| # run cpu sagemaker tests | |||
| - | | |||
| if has-matching-changes "test/" "tests/" "src/*.py" "docker/*" "buildspec.yml"; then | |||
| pytest test/integration/sagemaker --region $AWS_DEFAULT_REGION --docker-base-name $ECR_REPO --account-id $ACCOUNT --tag $CPU_TAG --py-version $CPU_PY_VERSION --instance-type $CPU_INSTANCE_TYPE | |||
| pytest test/integration/sagemaker -n 8 --region $AWS_DEFAULT_REGION --docker-base-name $ECR_REPO --account-id $ACCOUNT --tag $CPU_TAG --py-version $CPU_PY_VERSION --instance-type $CPU_INSTANCE_TYPE | |||
There was a problem hiding this comment.
why 8? (would auto make more sense?)
scripts/build_all.py
Outdated
| 'py2-gpu': args.py2_gpu_binary, | ||
| 'py3-gpu': args.py3_gpu_binary | ||
| } | ||
| build_dir = 'docker/{}'.format(args.version) |
scripts/build_all.py
Outdated
| # Run docker-login so we can pull the cached image | ||
| login_cmd = subprocess.check_output( | ||
| 'aws ecr get-login --no-include-email --registry-id {}'.format(args.account).split()) | ||
| print(login_cmd) |
There was a problem hiding this comment.
I'd preface each command with a description of what is being printed out. same goes for ll. 62 and 69 and similar lines in the other file
scripts/build_all.py
Outdated
| '-t {}:{} {}'.format(build_dir, arch, prev_image_uri, py_version, binary_file, args.repo, tag, build_dir) | ||
| print(build_cmd) | ||
| subprocess.check_call(build_cmd.split()) | ||
| print('Deleting binary file') |
There was a problem hiding this comment.
I'd add the binary file name to this print statement
scripts/publish_all.py
Outdated
| print(tag_cmd) | ||
| subprocess.check_call(tag_cmd.split()) | ||
| login_cmd = subprocess.check_output( | ||
| 'aws ecr get-login --no-include-email --registry-id {}'.format(args.account).split()) |
There was a problem hiding this comment.
add the region to this command
tox.ini
Outdated
| @@ -25,6 +25,7 @@ exclude = | |||
| venv/ | |||
| sagemaker-tensorflow-extensions | |||
| benchmarks/ | |||
| scripts/ | |||
There was a problem hiding this comment.
why exclude these? there are Python files written by us in that directory
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
laurenyu
approved these changes
May 20, 2019
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Run SM tests in parallel in PR build * Add release build spec and build scripts
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Run SM tests in parallel in PR build * Add release build spec and build scripts
Elizaaaaa
pushed a commit
to Elizaaaaa/sagemaker-tensorflow-container
that referenced
this pull request
Nov 4, 2019
* Run SM tests in parallel in PR build * Add release build spec and build scripts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.