Skip to content

fix: fix flake8 errors and add flake8 run in buildspec.yml #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019
Merged

fix: fix flake8 errors and add flake8 run in buildspec.yml #200

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion buildspec.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,11 @@ phases:
- pip3 install -U -e .
- pip3 install -U -e .[test]

# run flake8
- tox -e flake8

# run unit tests
- pytest test/unit
- tox -e py36,py27 test/unit

# Create pip archive
- build_dir="docker/$FRAMEWORK_VERSION"
Expand Down
4 changes: 2 additions & 2 deletions test/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ def skip_by_device_type(request, processor):

@pytest.fixture(autouse=True)
def skip_gpu_instance_restricted_regions(region, instance_type):
if((region in NO_P2_REGIONS and instance_type.startswith('ml.p2')) or
(region in NO_P3_REGIONS and instance_type.startswith('ml.p3'))):
if (region in NO_P2_REGIONS and instance_type.startswith('ml.p2')) or \
(region in NO_P3_REGIONS and instance_type.startswith('ml.p3')):
pytest.skip('Skipping GPU test in region {}'.format(region))


Expand Down