Skip to content

fix: fix integ test errors when running with py2 #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2019
Merged

fix: fix integ test errors when running with py2 #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eb008d
fix: fix integ test errors when running with py2
icywang86rui Jun 5, 2019
bee51e3
Merge branch 'script-mode' into shorter-tests
icywang86rui Jun 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/integration/local/test_horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import pytest
from sagemaker.tensorflow import TensorFlow

from test.integration.sagemaker.utils import processor, py_version # noqa: F401
from test.integration.utils import processor, py_version # noqa: F401

RESOURCE_PATH = os.path.join(os.path.dirname(__file__), '..', '..', 'resources')

Expand Down
2 changes: 1 addition & 1 deletion test/integration/local/test_keras.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
from sagemaker.tensorflow import serving, TensorFlow

from test.integration import RESOURCE_PATH
from test.integration.sagemaker.utils import processor, py_version # noqa: F401
from test.integration.utils import processor, py_version # noqa: F401


logging.basicConfig(level=logging.DEBUG)
Expand Down
2 changes: 1 addition & 1 deletion test/integration/local/test_training.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import pytest
from sagemaker.tensorflow import TensorFlow

from test.integration.sagemaker.utils import processor, py_version # noqa: F401
from test.integration.utils import processor, py_version # noqa: F401

RESOURCE_PATH = os.path.join(os.path.dirname(__file__), '..', '..', 'resources')
TF_CHECKPOINT_FILES = ['graph.pbtxt', 'model.ckpt-0.index', 'model.ckpt-0.meta']
Expand Down
2 changes: 1 addition & 1 deletion test/integration/sagemaker/test_horovod.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
import sagemaker
from sagemaker.tensorflow import TensorFlow

from utils import processor, py_version, unique_name_from_base # noqa: F401
from test.integration.utils import processor, py_version, unique_name_from_base # noqa: F401

RESOURCE_PATH = os.path.join(os.path.dirname(__file__), '..', '..', 'resources')

Expand Down
2 changes: 1 addition & 1 deletion test/integration/sagemaker/test_mnist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from sagemaker.tensorflow import TensorFlow
from six.moves.urllib.parse import urlparse

from utils import processor, py_version, unique_name_from_base # noqa: F401
from test.integration.utils import processor, py_version, unique_name_from_base # noqa: F401


@pytest.mark.deploy_test
Expand Down
2 changes: 1 addition & 1 deletion test/integration/sagemaker/test_tuning_model_dir.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from sagemaker.tensorflow import TensorFlow
from sagemaker.tuner import HyperparameterTuner, IntegerParameter

from utils import processor, py_version, unique_name_from_base # noqa: F401
from test.integration.utils import processor, py_version, unique_name_from_base # noqa: F401


def test_model_dir_with_training_job_name(sagemaker_session, ecr_image, instance_type, framework_version):
Expand Down
0 test/integration/sagemaker/utils.py → test/integration/utils.py
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions test/resources/mnist/mnist_estimator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def _parse_args():
parser = argparse.ArgumentParser()
parser.add_argument('--train', type=str, default=os.environ['SM_CHANNEL_TRAINING'])
parser.add_argument('--model_dir', type=str)
parser.add_argument('--max-steps', type=int, default=1000)
parser.add_argument('--save-checkpoint-steps', type=int, default=1000)
parser.add_argument('--max-steps', type=int, default=200)
parser.add_argument('--save-checkpoint-steps', type=int, default=200)
parser.add_argument('--throttle-secs', type=int, default=60)
parser.add_argument('--hosts', type=list, default=json.loads(os.environ['SM_HOSTS']))
parser.add_argument('--current-host', type=str, default=os.environ['SM_CURRENT_HOST'])
Expand Down