fix: flip master to script mode #222
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenyu
reviewed
Jul 24, 2019
|
|
||
| #. `Getting Started <#getting-started>`__ | ||
| #. `Building your Image <#building-your-image>`__ | ||
| #. `Running the tests <#running-the-tests>`__ |
There was a problem hiding this comment.
why not let it be automatically generated anymore?
| @@ -65,10 +66,10 @@ The "base" Dockerfile encompass the installation of the framework and all of the | |||
| needed. It is needed before building image for TensorFlow 1.8.0 and before. | |||
| Building a base image is not required for images for TensorFlow 1.9.0 and onwards. | |||
|
|
|||
| Tagging scheme is based on <tensorflow_version>-<processor>-<python_version>. (e.g. 1.4 | |||
| Tagging scheme is based on <tensorflow_version>-<processor>-<python_version>. (e.g. 1.4 | |||
| .1-cpu-py2) | |||
There was a problem hiding this comment.
that's a weird line break haha
| @@ -272,10 +237,10 @@ Functional Tests | |||
| Functional tests require your Docker image to be within an `Amazon ECR repository <https://docs | |||
| .aws.amazon.com/AmazonECS/latest/developerguide/ECS_Console_Repositories.html>`__. | |||
|
|
|||
| The `docker-base-name` is your `ECR repository namespace <https://docs.aws.amazon | |||
| The Docker-base-name is your `ECR repository namespace <https://docs.aws.amazon | |||
There was a problem hiding this comment.
remove the dashes from "Docker base name"
| .com/AmazonECR/latest/userguide/Repositories.html>`__. | ||
|
|
||
| The `instance-type` is your specified `Amazon SageMaker Instance Type | ||
| The instance-type is your specified `Amazon SageMaker Instance Type |
There was a problem hiding this comment.
s/instance-type/instance type
laurenyu
reviewed
Jul 24, 2019
| @@ -1,19 +1,38 @@ | |||
| import os | |||
| # Copyright 2017-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
|
closing in favor of #234 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change copies the tip of script-mode branch.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.