fix: add condition to avoid error when 'model_dir' is None #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
icywang86rui
approved these changes
Oct 16, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
metrizable
approved these changes
Oct 16, 2020
| @@ -204,7 +204,7 @@ def _log_model_missing_warning(model_dir): | |||
|
|
|||
|
|
|||
| def _model_dir_with_training_job(model_dir, job_name): | |||
| if model_dir.startswith("/opt/ml"): | |||
| if model_dir and model_dir.startswith("/opt/ml"): | |||
| return model_dir | |||
| else: | |||
| return "{}/{}/model".format(model_dir, job_name) | |||
There was a problem hiding this comment.
f-string?
Suggested change
| return "{}/{}/model".format(model_dir, job_name) | |
| return f"{model_dir}/{job_name}/model" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
aws/sagemaker-python-sdk#1954
Description of changes:
Check
model_diris not None or False before checking its content.When
TensorFlow.model_diris set to False, the current logic will raise error.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.