Skip to content

Add benchmarking script #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2018
Merged

Add benchmarking script #86

merged 2 commits into from
Oct 23, 2018

Conversation

mvsusp
Copy link
Contributor

@mvsusp mvsusp commented Oct 9, 2018

Description of changes:
Add benchmarking script

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mvsusp mvsusp requested a review from icywang86rui October 9, 2018 23:23

- role: SageMaker role used for training
- region: SageMaker region
- py-versions: py2 or py3 or py2, py3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"py2 or py3"

- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training
- checkpoint-path: The S3 location where the model checkpoints and tensorboard events are saved after training

Any additional argument will be passed to the training script as additional argument
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/addtional/unknown
s/argument/arguments

- role: SageMaker role used for training
- region: SageMaker region
- py-versions: py2 or py3 or py2, py3
- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this support a list? If so what's the delimiter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List. I will update the docs.

Copy link
Contributor Author

@mvsusp mvsusp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made suggested changes from the PR

- role: SageMaker role used for training
- region: SageMaker region
- py-versions: py2 or py3 or py2, py3
- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

List. I will update the docs.

@mvsusp mvsusp merged commit a1916a8 into aws:script-mode Oct 23, 2018
@mvsusp mvsusp deleted the mvs-benchmarchs branch October 23, 2018 21:51
Elizaaaaa pushed a commit to Elizaaaaa/sagemaker-tensorflow-container that referenced this pull request Nov 4, 2019
* Add benchmarking script
Elizaaaaa pushed a commit to Elizaaaaa/sagemaker-tensorflow-container that referenced this pull request Nov 4, 2019
* Add benchmarking script
Elizaaaaa pushed a commit to Elizaaaaa/sagemaker-tensorflow-container that referenced this pull request Nov 4, 2019
* Add benchmarking script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants