-
Notifications
You must be signed in to change notification settings - Fork 162
Add benchmarking script #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
benchmarks/README.md
Outdated
|
||
- role: SageMaker role used for training | ||
- region: SageMaker region | ||
- py-versions: py2 or py3 or py2, py3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"py2 or py3"
benchmarks/README.md
Outdated
- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training | ||
- checkpoint-path: The S3 location where the model checkpoints and tensorboard events are saved after training | ||
|
||
Any additional argument will be passed to the training script as additional argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/addtional/unknown
s/argument/arguments
benchmarks/README.md
Outdated
- role: SageMaker role used for training | ||
- region: SageMaker region | ||
- py-versions: py2 or py3 or py2, py3 | ||
- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this support a list? If so what's the delimiter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List. I will update the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made suggested changes from the PR
benchmarks/README.md
Outdated
- role: SageMaker role used for training | ||
- region: SageMaker region | ||
- py-versions: py2 or py3 or py2, py3 | ||
- instance-types: SageMaker instance types, for example 'ml.p2.xlarge', use 'local' for local mode training |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
List. I will update the docs.
* Add benchmarking script
* Add benchmarking script
* Add benchmarking script
Description of changes:
Add benchmarking script
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.