Add the download functionality to the Spring BOOT Photo example #1933

scmacdon · 2021-07-21T17:26:16Z

aws-doc-sdk-examples Pull Request

Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.

NOTE: This PR template contains three sections. Depending on the reason for your pull request, please fill out the section that applies to you and then remove the other two sections.

New SDK Code Example

The submitter has:

Added the default copyright notice to all files.
Created unit tests for all paths through the code and they all pass.
Run a linter against all code and implemented the resulting suggestions.
Added minimum usage documentation as comments in the code.
Had comments and strings reviewed and incorporated suggested changes.
Had the code reviewed and implemented the reviewer's suggested changes.

Existing Example Update

The submitter has:

Confirmed that the correct copyright is included in all files.
Major code changes have been reviewed, and the submitter has incorporated review comments.
Changed or added comments and strings have been reviewed, and the submitter has incorporated any and all suggested edits.

Resolve Issue

Issue #

Description of Changes

Please describe the changes you have made here.

I have tested my changes and created unit tests for new code paths.
Changes have been reviewed, and all reviewer comments have been incorporated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

irenepsmith

A few minor changes.

irenepsmith · 2021-07-21T17:51:45Z

javav2/example_code/ecs/Readme.md

@@ -0,0 +1,80 @@
+# Amazon Elastic Container Service Java code examples
+


First time: Amazon Elastic Container Service (Amazon ECS)
Second time: Amazon ECS
Third and so on: ECS

This is located in the first sentence.

irenepsmith · 2021-07-22T12:27:31Z

javav2/example_code/ecs/src/test/java/EcsTest.java

+                return;
+            }
+
+            //load a properties file from class path, inside static method


load -> Load

Also a period at the end of the sentence.

irenepsmith · 2021-07-22T12:28:57Z

javav2/example_code/ecs/src/test/java/EcsTest.java

+            //load a properties file from class path, inside static method
+            prop.load(input);
+
+            // Populate the data members required for all tests


Period at the end of the sentence.

irenepsmith · 2021-07-22T12:30:45Z

javav2/usecases/creating_photo_analyzer_app/Readme.md

@@ -410,7 +415,7 @@ The following Java code represents the **PhotoController** class that handles HT
    return s3Client.ListAllObjects("scottphoto");
    }

-    // Generate a report that analyzes photos in a given bucket
+    // generates a report that analyzes photos in a given bucket


generate -> Generate and a period at the end of the sentence.

irenepsmith · 2021-07-22T12:31:18Z

javav2/usecases/creating_photo_analyzer_app/Readme.md

@@ -420,18 +425,18 @@ The following Java code represents the **PhotoController** class that handles HT
       // Get a list of key names in the given bucket
       List myKeys =  s3Client.ListBucketObjects("scottphoto");

-       // Create a list to store the data
-       List myList = new ArrayList<List>();
+       // Create a List to store the data


Period at the end of the sentence.

irenepsmith · 2021-07-22T12:43:41Z

javav2/usecases/creating_photo_analyzer_app/Readme.md

@@ -420,18 +425,18 @@ The following Java code represents the **PhotoController** class that handles HT
       // Get a list of key names in the given bucket


Period at the end of the sentence.

irenepsmith · 2021-07-22T12:45:24Z

javav2/usecases/creating_photo_analyzer_app/Readme.md


-       // Loop through each element in the List
+       // loop through each element in the List
       int len = myKeys.size();
       for (int z=0 ; z < len; z++) {

           String key = (String) myKeys.get(z);
           byte[] keyData = s3Client.getObjectBytes ("scottphoto", key);
           //myMap.put(key, keyData);


This should probably be removed?

irenepsmith · 2021-07-22T12:47:04Z

...v2/usecases/creating_photo_analyzer_app/src/main/java/com/example/photo/PhotoController.java

@@ -51,7 +58,6 @@ String getImages(HttpServletRequest request, HttpServletResponse response) {
    return s3Client.ListAllObjects("scottphoto");
    }

-
    // generates a report that analyzes photos in a given bucket


generates -> Generates and a period at the end of the sentence.

irenepsmith · 2021-07-22T12:47:29Z

...v2/usecases/creating_photo_analyzer_app/src/main/java/com/example/photo/PhotoController.java

@@ -63,7 +69,7 @@ String report(HttpServletRequest request, HttpServletResponse response) {
       List myKeys =  s3Client.ListBucketObjects("scottphoto");

       // Create a List to store the data


irenepsmith · 2021-07-22T12:48:01Z

...v2/usecases/creating_photo_analyzer_app/src/main/java/com/example/photo/PhotoController.java

@@ -63,7 +69,7 @@ String report(HttpServletRequest request, HttpServletResponse response) {
       List myKeys =  s3Client.ListBucketObjects("scottphoto");

       // Create a List to store the data
-       List myList = new ArrayList<List>();
+       List<List> myList = new ArrayList<List>();

       // loop through each element in the List


loop -> Loop and a period at the end of the sentence.

irenepsmith

LGTM -- thanks!

scmacdon and others added 30 commits June 28, 2021 12:34

Create Readme.md

703ed23

Create CreateCluster.java

93ebd23

Add files via upload

16d34d3

Update Readme.md

f8a65e2

Create EcsTest.java

48bf1f7

Create config.properties

355805b

Update Readme.md

ace73c1

Add files via upload

f26c006

Add files via upload

b717371

Add files via upload

8de04ca

Update ArchiveDownload.java

80ccb81

Update DescribeInstanceTags.java

6130704

Update Readme.md

362c565

Update Readme.md

21bcfe0

Update Readme.md

48068bd

Update Readme.md

f0ca736

Update ArchiveDownload.java

9e4da77

Merge branch 'master' into master

55c1555

Update Readme.md

8c36ff4

Add files via upload

3fbac8e

Update Readme.md

8d2712f

Update PhotoController.java

f29a7c2

Update AnalyzePhotos.java

aff2e90

Update BucketItem.java

f9fe39c

Update PhotoApplication.java

e643fcb

Update S3Service.java

d8f96f8

Update SendMessages.java

8c002e2

Update WorkItem.java

d58a1da

Update WriteExcel.java

d0d0abd

Update Readme.md

2a83821

scmacdon added 2 commits July 21, 2021 13:24

Update process.html

a163e88

Update message.js

f037824

irenepsmith self-assigned this Jul 21, 2021

irenepsmith suggested changes Jul 22, 2021

View reviewed changes

scmacdon added 8 commits July 22, 2021 10:33

Update Readme.md

b42fa25

Update Readme.md

24993be

Update S3Service.java

4cdbfbf

Update PhotoController.java

dc4911e

Update Readme.md

97cebed

Update PhotoController.java

cc83dc2

Update Readme.md

9b84e88

Update EcsTest.java

6b2bd1d

irenepsmith approved these changes Jul 22, 2021

View reviewed changes

scmacdon and others added 2 commits July 22, 2021 11:44

Delete EcsTest.java

b4f2dd7

Merge branch 'master' into master

28b7971

irenepsmith merged commit 74bc078 into awsdocs:master Jul 22, 2021

		@@ -0,0 +1,80 @@
		# Amazon Elastic Container Service Java code examples

		@@ -420,18 +425,18 @@ The following Java code represents the PhotoController class that handles HT
		// Get a list of key names in the given bucket

		@@ -63,7 +69,7 @@ String report(HttpServletRequest request, HttpServletResponse response) {
		List myKeys = s3Client.ListBucketObjects("scottphoto");

		// Create a List to store the data

Add the download functionality to the Spring BOOT Photo example #1933

Add the download functionality to the Spring BOOT Photo example #1933

Uh oh!

Conversation

scmacdon commented Jul 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

aws-doc-sdk-examples Pull Request

New SDK Code Example

Existing Example Update

Resolve Issue

Description of Changes

Uh oh!

irenepsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

irenepsmith left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

scmacdon commented Jul 21, 2021 •

edited

Loading