Skip to content

Swift: code examples for Meta Llama to use Converse and ConverseStream, Amazon Bedrock #7434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025

Conversation

monadierickx
Copy link
Contributor

This pull request contains code examples for Meta Llama similar to the examples for Amazon Nova.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the Swift This issue relates to the AWS SDK for Swift label May 6, 2025
Copy link

@sebsto sebsto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, two minor change requests

@monadierickx monadierickx marked this pull request as ready for review May 6, 2025 11:12
@DennisTraub DennisTraub self-requested a review May 20, 2025 07:04
Copy link
Contributor

@DennisTraub DennisTraub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brmur brmur added Feature Scenario A simple code example to show how certain tasks can be accomplished using several services and SDKs. On Call Review complete On call review complete and removed On Call Review complete On call review complete labels May 28, 2025
Copy link
Contributor

@shepazon shepazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsto
Copy link

sebsto commented Jun 5, 2025

@DennisTraub @shepazon How can we get this merged ?

@shepazon shepazon added the On Call Review needed This work needs an on-call review label Jun 5, 2025
@scmacdon scmacdon added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jun 6, 2025
@scmacdon
Copy link
Contributor

scmacdon commented Jun 6, 2025

There seems to be a conflict here that needs to be fixed

@scmacdon scmacdon merged commit 85042e5 into awsdocs:main Jun 6, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Scenario A simple code example to show how certain tasks can be accomplished using several services and SDKs. On Call Review complete On call review complete Swift This issue relates to the AWS SDK for Swift
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants