Skip to content

Preserve the JMS Correlation ID when sending and receiving messages #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2019

Conversation

candrews
Copy link
Contributor

Fixes #19

@candrews
Copy link
Contributor Author

@robin-aws this is the PR we discussed on our call.

@robin-aws
Copy link
Collaborator

Thanks Craig. Looks good to me as this is an obvious bug (since setJMSCorrelationID() currently succeeds rather than throwing an exception).

As I mentioned earlier, we are unfortunately not set up well to accept pull requests just yet, but I will make sure this makes it into the next release.

@candrews
Copy link
Contributor Author

@robin-aws do you know when the next release may be?

@robin-aws
Copy link
Collaborator

Hi Craig. We don't have an ETA at the moment but we are about due for another release. I'll discuss with the team and get back to you in a day or two.

@sullis
Copy link
Contributor

sullis commented Nov 29, 2018

what is the status of this PR?

@robin-aws
Copy link
Collaborator

Hi sullis - I'm happy to say I have a solution to the build issues that makes it difficult for us to accept pull requests, and I'm implementing it this week. Once I'm confident it will work I'm happy to accept this PR and then quickly create a release for this and a few other lingering PRs. Thanks for your patience!

@candrews
Copy link
Contributor Author

Another 5 weeks have passed...

@robin-aws
Copy link
Collaborator

Hi Craig. My apologies for the further delays. I've had some trouble with our integration tests that are blocking creating releases. In the meantime, though, I'm happy to at least accept this PR since it's very low risk.

@robin-aws robin-aws merged commit d0a396b into awslabs:master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants