receiveNoWait() without prefetching #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also tag the artifact version to help the build process.
robin-aws
changed the title
|
Waited for the release. |
|
I see what you did there. :) Released in 1.0.7 |
robin-aws
added a commit
that referenced
this pull request
Aug 7, 2019
As per #77, closed consumers should only return null from concurrent in-flight receive calls, not future ones, and returning null doesn't play nice with SpringJMS. Checking in SQSMessageConsumer is more consistent than in SQSMessageConsumerPrefetch, and easier to test to boot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses receiveNoWait() not returning any messages if prefetching is turned off.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.