Mark MessageListener as ready on prefetch start #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting MessageListener before starting prefetch would not mark the message listener as ready. Therefore start() method should do this work in order to get pre-fetch going even when number of messages to pre-fetch is set to 0. Closes awslabs#86
|
It's not quite obvious but call to |
|
@haocheng-aws Thanks for merging this PR. Could you please advise when the next release would be? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting MessageListener before starting prefetch would
not mark the message listener as ready. Therefore start()
method should do this work in order to get pre-fetch
going even when number of messages to pre-fetch is set to 0.
Closes #86