Skip to content

Change validation exceptions to unchecked exceptions #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

markkuhn
Copy link
Contributor

Description of changes:

With the release of version 4, we introduced validation features aimed at providing immediate feedback on invalid properties and metrics. This proactive approach was designed to save customers time by eliminating the need to troubleshoot missing metrics in CloudWatch. Initially, we implemented these validations as checked exceptions to ensure they were explicitly handled.

However, after careful consideration of recent customer feedback, we recognize that this design choice may not align with all use cases. To offer a more flexible integration, we are transitioning our validation exceptions from checked to unchecked. This change is intended to streamline error handling and improve the overall developer experience.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@markkuhn markkuhn added the enhancement New feature or request label Nov 24, 2023
@markkuhn markkuhn requested a review from giancarlokc November 24, 2023 23:45
@markkuhn markkuhn self-assigned this Nov 24, 2023
@markkuhn
Copy link
Contributor Author

Closes #140

@markkuhn markkuhn marked this pull request as ready for review November 27, 2023 17:52
@markkuhn markkuhn requested a review from evanuk November 27, 2023 17:52
@markkuhn markkuhn merged commit 39f61f9 into awslabs:master Nov 28, 2023
@markkuhn markkuhn linked an issue Nov 29, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of checked exceptions
3 participants