Skip to content

send the runtime user agent when polling for events #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

send the runtime user agent when polling for events #180

merged 1 commit into from
Dec 6, 2019

Conversation

bmoffatt
Copy link
Contributor

@bmoffatt bmoffatt commented Dec 6, 2019

Issue #, if available:

N/A

Description of changes:

The user agent was only getting set here and here. This means that Lambda is unable to know what the runtime version is when the function crashes or times out.

By submitting this pull request

  • [ ✅] I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • [ ✅] I confirm that I've made a best effort attempt to update all relevant documentation.

@davidbarsky davidbarsky self-requested a review December 6, 2019 20:01
davidbarsky
davidbarsky approved these changes Dec 6, 2019
View reviewed changes
Copy link
Contributor

@davidbarsky davidbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry we weren't sending this information to y'all 😅

@davidbarsky davidbarsky merged commit c8d97d3 into awslabs:master Dec 6, 2019
@ewbankkit ewbankkit mentioned this pull request Apr 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbarsky davidbarsky davidbarsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmoffatt @davidbarsky